Add global size parameters to Params class#1712
Merged
Merged
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
Fix typo in doctoring
k034b363
approved these changes
Jun 2, 2025
k034b363
left a comment
k034b363
left a comment
Contributor
There was a problem hiding this comment.
Checked docs and made sure the new params show up as expected in a notebook. Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add global size parameters (
unitpx_widthandpx_height) toParamsclass to prepare for functionality support to do size scaling directly during analysis steps. Also update documentation page to include the new parameters.Associated issues
Additional context
Next steps: PR2: use units/px factors in analyze functions; PR3: sets global params given color card chip sizes
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md